Github user vkadam commented on a diff in the pull request:

    https://github.com/apache/incubator-atlas/pull/6#discussion_r38167128
  
    --- Diff: dashboard/v2/.bowerrc ---
    @@ -1,5 +1,5 @@
     {
    -  "directory": "dist/lib",
    +  "directory": "public/lib",
    --- End diff --
    
    Why it should be in target? Its required runtime and not only compile time 
like java classes. While creation of war dist folder gets added to it. Dist 
folder is create from public folder with minified files.
    If we move it to target folder then every mvn clean it will get deleted and 
which will need bower to download it again. Which defeats the purpose of whole 
offline build support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to