----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38179/ -----------------------------------------------------------
(Updated Sept. 23, 2015, 4:40 p.m.) Review request for atlas and Harish Butani. Bugs: ATLAS-128 https://issues.apache.org/jira/browse/ATLAS-128 Repository: atlas Description (updated) ------- 1. Supporting equality matches on array type as array_type_col_name = [ List of values ] where list of values is a comma separated list of literals which are of primitive type like string, int, etc 2. Changed DSL tests - Gremlin, Expression, GraphBackedDiscoveryServiceTest to use the DefaultGraphPersistenceStrategy instead of the inmemory one so that the real code execution path is tested 3. Fixed ATLAS-30 - Fixed tests in GraphBackedDiscoveryServiceTest to validate expected test results 4. Fixed "typename has fieldname" queries where fieldname was not getting fully qualified with typeName. 5. 5. Fixed "type is trait" queries - trait label did not have __ Could not complete load of list types due to issues with validation in DSL. Will be covering this in a separate jira. Diffs ----- addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 589ef16 repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java c446d15 repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 97d1fe2 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java b44ce60 repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java 6605ae7 repository/src/main/scala/org/apache/atlas/query/Expressions.scala 24fa917 repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala 2cec503 repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 75fa916 repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 5b129fb repository/src/main/scala/org/apache/atlas/query/Resolver.scala 142ba8d repository/src/test/java/org/apache/atlas/BaseHiveRepositoryTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java c72ffb2 repository/src/test/java/org/apache/atlas/discovery/HiveLineageServiceTest.java db51ae5 repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java bec3067 repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java 20781db repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala 957a566 repository/src/test/scala/org/apache/atlas/query/GremlinTest2.scala ea0b9bb repository/src/test/scala/org/apache/atlas/query/HiveTitanSample.scala c662847 repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala 0b4dd2b repository/src/test/scala/org/apache/atlas/query/ParserTest.scala 602b2b5 repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 3c66da0 typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java e35453e Diff: https://reviews.apache.org/r/38179/diff/ Testing ------- Tests added in Parser, GremlinTest, GraphBackedDiscoveryTest Thanks, Suma Shivaprasad