[ 
https://issues.apache.org/jira/browse/ATLAS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065352#comment-15065352
 ] 

Hemanth Yamijala commented on ATLAS-402:
----------------------------------------

I have tested this patch:

* Added a tag to an entity. Shows the confirmation that tag is added.
* Tried to add again, shows an error message.
* Closed everything. Tried to add the same tag again in a fresh flow. Shows the 
error message.

A few minor improvements possible:

The error message says: "Trait=Test1 Is Already Defined For 
Entity=1af1f9aa-3085-44ae-Aa48-92d44f..." - At many places we are trying to 
avoid showing GUIDs. So, we could just say "Tag 'Test1' is already defined for 
this entity." -> Note I've used the word 'Tag' because that's what it is called 
in the UI. The term 'Trait' is very technical and used only for our APIs. By 
making the message generic - like "for this entity" - we can avoid having to 
show the GUIDs etc without taking away meaning.


> UI : Validation of Associating a Tag   
> ---------------------------------------
>
>                 Key: ATLAS-402
>                 URL: https://issues.apache.org/jira/browse/ATLAS-402
>             Project: Atlas
>          Issue Type: Bug
>    Affects Versions: 0.6-incubating
>            Reporter: Darshan Kumar
>            Assignee: Darshan Kumar
>              Labels: patch-available
>         Attachments: ATLAS-401-ATLAS-402-v0.patch, ATLAS-402-v1.patch, 
> ATLAS-402.patch
>
>
> Tag association  - no confirmation when linking it to an asset.  I click save 
> the second time and I get an error saying its already there… so I know it 
> works but we should confirm or close the window



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to