[ 
https://issues.apache.org/jira/browse/ATLAS-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096256#comment-15096256
 ] 

Hemanth Yamijala commented on ATLAS-433:
----------------------------------------

Verified the changes in the patch. Looks good to me. 

One minor thing to consider, I guess checkstyle requires a class documentation 
for public classes, because of which this has been added to many classes. 
However, can we turn off this check for test classes at least, as they really 
add no value and only cause overhead? We could consider this change for other 
checkstyle JIRAs that are going to come through.

> Fix checkstyle issues for common and notification module
> --------------------------------------------------------
>
>                 Key: ATLAS-433
>                 URL: https://issues.apache.org/jira/browse/ATLAS-433
>             Project: Atlas
>          Issue Type: Sub-task
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>             Fix For: trunk
>
>         Attachments: ATLAS-433.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to