----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43531/#review119329 -----------------------------------------------------------
Changes for ATLAS-480 look good. - David Kantor On Feb. 16, 2016, 3:55 p.m., Neeru Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43531/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 3:55 p.m.) > > > Review request for atlas and David Kantor. > > > Repository: atlas > > > Description > ------- > > Ability to specify description while creating different types like Struct, > Enum, Class and Trait type. > > https://issues.apache.org/jira/browse/ATLAS-479 > > Ability to update description. > > https://issues.apache.org/jira/browse/ATLAS-480 > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/Constants.java > 1b4cb367f652b375fd9de85ac6e9943f4dcdd06a > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 9789be7eea7078e92b21aac7eef66e924ca0ca0b > repository/src/test/java/org/apache/atlas/TestUtils.java > 653ec01660166f9aeefff4bdc38e376b6b2e5e3b > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > 8402eed5478d87187adad03c200c5f3eb3b7f68d > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > ea0d8e8403bd796fbf5ea9ad707f0a3e8f33c3bf > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java > ed0400aaca1bb7f218262b91991d4b5c9a43fa38 > typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java > adf5f1c96f2eaa4a3b514789ee474a7683e91fa8 > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumType.java > b7513079ab7575aba10c43dbd95e93cd208a95ae > > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java > aca1a410a8b96e9ec02281cd1bbeb97fa62cd61c > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java > 5a331a67bbab5b4644e61ae85d3d1c806a386812 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java > 3188840ea411b900683d5d5e99993bc5034dc323 > typesystem/src/main/java/org/apache/atlas/typesystem/types/IDataType.java > 293014e22eb0f2cd2871964628e1cf362e497801 > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java > ba053d24c06b8cec9b8949cdb5a1e282a9058581 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java > e47c4e58eee0b69857fb897986563d3bc42f8e1e > typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java > f5a387516d63f11287e97628a5190b9f8c5ecb1b > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > c0b06982d7fd92d21c659ee4df3233c0d3ce1478 > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java > f5c2ce9e296850e8db91aa24b51020f5538fecb6 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java > ee82ce56749a022fcdb1094595d7c7fac53c9247 > > typesystem/src/main/scala/org/apache/atlas/typesystem/json/TypesSerialization.scala > 6bdbc796cf2e5e8119f43a07c753d35c3051e35d > > typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java > eb472e9186e9d4c2416822a3e45d3f7b9903513b > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java > 0a6b7b9ebf5bc5f920c548370cf3c29801056f57 > > Diff: https://reviews.apache.org/r/43531/diff/ > > > Testing > ------- > > Have added new test cases to create different types with description > > > Thanks, > > Neeru Gupta > >
