----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45948/#review128589 -----------------------------------------------------------
typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java (line 51) <https://reviews.apache.org/r/45948/#comment192038> This may not be a valid case - maybe Shwetha would know better... but if a FieldMapping instance's output is called from different threads, wouldn't this mutable state cause issues? Can't think of an easy way to fix that very quickly though. So please take a call based on whether it is a valid use case or not. - Hemanth Yamijala On April 12, 2016, 1:41 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45948/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 1:41 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-645 > https://issues.apache.org/jira/browse/ATLAS-645 > > > Repository: atlas > > > Description > ------- > > ATLAS-645: In FieldMapping.output(), avoid infinite recursion when > IReferenceableInstance and IStruct instances reference each other. > > > Diffs > ----- > > > typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java > 36149bafff80b68ce176e82dcacac87035459362 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45948/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. Added test cases > > > Thanks, > > David Kantor > >
