[
https://issues.apache.org/jira/browse/ATLAS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241736#comment-15241736
]
Suma Shivaprasad commented on ATLAS-532:
----------------------------------------
Replies inline to [~yhemanth]'s review comments
We have defined constants for createTime etc in HiveMetaStoreBridge. It would
be really nice if we could define these in HiveDataModelGenerator and use them
both there and in other referring places. Similarly for the process related
attributes.
-> Fixed
In HiveHookIT.verifyTimestamps, there is an extraneous line:
TypeSystem.getInstance().getDateFormat().parse(createTimeStr);. I don't think
this is required, as it is being assigned to a variable before.
-> Fixed
I saw that in Falcon and Storm we are still referring to timestamps as long
datatypes. (Sqoop and HDFS seem fine). Ideally we would want to change those
too. We could certainly take these as part of another JIRA. Could you please
file that, if we take that path?
--> Raised ATLAS-674 and ATLAS-675 for the same.
Would the API start serializing these differently now? If yes, any impact on
existing apps including Åtlas's own UI that we need to call out? (Maybe mark
these as incompatible changes and announce on the dev list etc)
--> API serializes as String and UI is working fine with this. Attaching
snapshot of tests
> Change Data types of all timestamps(currently long)
> ---------------------------------------------------
>
> Key: ATLAS-532
> URL: https://issues.apache.org/jira/browse/ATLAS-532
> Project: Atlas
> Issue Type: Sub-task
> Affects Versions: 0.6-incubating, 0.7-incubating
> Reporter: Suma Shivaprasad
> Assignee: Suma Shivaprasad
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-532.1.patch, ATLAS-532.2.patch, ATLAS-532.3.patch,
> ATLAS-532.patch
>
>
> startTime, endTime, createTime to date
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
