> On April 15, 2016, 6:17 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java, > > line 43 > > <https://reviews.apache.org/r/45929/diff/3/?file=1344545#file1344545line43> > > > > TitanGraphProvider has some RunTimeExceptions. We could change that to > > SetupException. Also not sure what Titan throws when graph schema errors > > occur, what do they throw..should we wrap them in this?
I am catching the exceptions thrown from here in the GraphSchemaInitializer's setup and throwing it back as a SetupException. I also checked the calls from Titan when schema error occurs - they are mostly RuntimeExceptions - NullPointerException, IllegalArgumentException, etc. So, having a catch-all and rethrowing it as a SetupException will handle those. - Hemanth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45929/#review129165 ----------------------------------------------------------- On April 14, 2016, 3:24 p.m., Hemanth Yamijala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45929/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 3:24 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-628 > https://issues.apache.org/jira/browse/ATLAS-628 > > > Repository: atlas > > > Description > ------- > > Implements capability in atlas to run a set of registered setup steps. > Currently the only step is setting up the backend graph repository. The > intent is to extend this later for setting up Kafka at least and maybe other > things like Solr. > > > Diffs > ----- > > distro/src/bin/atlas_start.py 7db74c0 > distro/src/conf/atlas-application.properties 4131240 > docs/src/site/twiki/Configuration.twiki 023f5a0 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java > PRE-CREATION > server-api/src/main/java/org/apache/atlas/setup/SetupException.java > PRE-CREATION > server-api/src/main/java/org/apache/atlas/setup/SetupStep.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/Atlas.java 58c386d > webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java > 773e04e > webapp/src/main/java/org/apache/atlas/web/setup/AtlasSetup.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/setup/AtlasSetupModule.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java > PRE-CREATION > webapp/src/test/java/org/apache/atlas/web/setup/SetupStepsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45929/diff/ > > > Testing > ------- > > Existing ITs, UTs pass. > > * Manually verified setting up with both embedded HBase setup and external > HBase setup. > * Also ran atlas HA instances at exactly same time and verified the noted > exception does not happen. > > > Thanks, > > Hemanth Yamijala > >
