[ 
https://issues.apache.org/jira/browse/ATLAS-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270512#comment-15270512
 ] 

Hemanth Yamijala commented on ATLAS-658:
----------------------------------------

[~kevalbhatt18], [~bergenholtz], UI indeed looks good for lineage. Things were 
fine with quick start data. However, there are few issues with hive data when I 
tested the integration. Can you please look into these:

* The logic to determine when to show a dataset (table) icon and when to show a 
process (gear) icon seems wrong. So, the code is explicitly checking for type 
== "Table" which is a problem (in {{LineageLayoutView.js}}), because there are 
other data types (hive_table, kafka_topic, etc). Because of the hardcoding, 
right now we are showing a gear icon for hive_tables as well. The dashboard v1 
code had developed some logic to determine which is a dataset and which is a 
process. The same should be replicated here, I think.

* I ran couple of hive queries as follows:
{code}
create table test1(id int, name string, description string);
create table test1_ctas as select name, count(name) from test1 group by name;
create table test1_ctas2 as select id, count(name) from test1 group by id;
{code}
With these, the expected lineage is that test1 should have one set of edges 
leading to test1_ctas and another to test1_ctas2. In the lineage that shows up, 
only one set of edges are seen, although all vertices are seen. I will upload 
the image of the lineage graph so you can relate to this comment with the name 
{{atlas_658_hive_lineage_issues.png}}.

> Improve Lineage with Backbone porting 
> --------------------------------------
>
>                 Key: ATLAS-658
>                 URL: https://issues.apache.org/jira/browse/ATLAS-658
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Keval Bhatt
>            Assignee: Keval Bhatt
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-658.patch
>
>
> Improved display of vertices and edges in lineage graph that gets generated. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to