> On May 4, 2016, 7:34 a.m., Hemanth Yamijala wrote: > > client/src/main/java/org/apache/atlas/AtlasAdminClient.java, line 63 > > <https://reviews.apache.org/r/46650/diff/1/?file=1360346#file1360346line63> > > > > Not related to this patch, but since we are touching it, should we just > > get currentUGI and shortUserName here, as we are doing in quick start?
Will add in AtlasClient itself > On May 4, 2016, 7:34 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java, line 122 > > <https://reviews.apache.org/r/46650/diff/1/?file=1360357#file1360357line122> > > > > EntityResource is marked as a Singleton resource. While this doesn't > > prevent creation of multiple instances, it might just be confusing (for > > e.g. if someone makes changes to EntityResource on the basis of this). I > > don't feel strongly about it, but if we can do something (either remove the > > annotation, or get a single instance here) it might be nice to do. I wanted to override HttpServletRequest, but something didn't work at that time. I will try to clean it up > On May 4, 2016, 7:34 a.m., Hemanth Yamijala wrote: > > webapp/src/main/java/org/apache/atlas/web/util/Servlets.java, line 86 > > <https://reviews.apache.org/r/46650/diff/1/?file=1360365#file1360365line86> > > > > For my understanding, will any of our current clients be sending this > > query parameter? AtlasClient uses DelegationTokenAuthenticatedURL which always sets doAs param. If there is proxy, there will be both doAs and user.name params. Without proxy, there will be just doAs param. So, everyone who uses AtlasClient will set doAs param - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46650/#review131623 ----------------------------------------------------------- On April 25, 2016, 6:15 p.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46650/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 6:15 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-585 > https://issues.apache.org/jira/browse/ATLAS-585 > > > Repository: atlas > > > Description > ------- > > Added local atlas client that calls the resources directly. So, it bypasses > the filters > > > Diffs > ----- > > addons/falcon-bridge/pom.xml 9b07c9f > addons/hive-bridge/pom.xml e125f18 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 104c0c5 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > b0d4c5c > addons/sqoop-bridge/pom.xml 4b5dbb1 > addons/storm-bridge/pom.xml d8d98f5 > client/src/main/java/org/apache/atlas/AtlasAdminClient.java 473f72a > client/src/main/java/org/apache/atlas/AtlasClient.java be34802 > client/src/main/java/org/apache/atlas/AtlasServiceException.java 6f68a71 > client/src/main/java/org/apache/atlas/security/SecureClientUtils.java > d3b474a > client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5 > distro/src/conf/atlas-log4j.xml 1ac4082 > > notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 1f2df3e > > notification/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java > 177de6d > pom.xml 729b178 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > d83c08c > webapp/pom.xml 1df4112 > webapp/src/main/java/org/apache/atlas/LocalAtlasClient.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > PRE-CREATION > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > 01b1cd3 > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > 1eca174 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 6068007 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > b14aa80 > webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java > 74d89ce > webapp/src/main/java/org/apache/atlas/web/util/Servlets.java 480a232 > webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > 03a0d3f > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterIT.java > 9e1e08f > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java > PRE-CREATION > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterIT.java > ca53096 > > webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationSimpleFilterTest.java > PRE-CREATION > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 54d8d92 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 720ce79 > > webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java > d497230 > webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java > 270a20d > webapp/src/test/java/org/apache/atlas/web/security/SSLTest.java 521c037 > > Diff: https://reviews.apache.org/r/46650/diff/ > > > Testing > ------- > > UTs and end to end test > > > Thanks, > > Shwetha GS > >
