----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46731/#review131952 -----------------------------------------------------------
client/src/main/java/org/apache/atlas/AtlasClient.java (line 577) <https://reviews.apache.org/r/46731/#comment195990> would be better to keep the result consistent for all CRUD operations and standardize as EntityResult - Suma Shivaprasad On April 27, 2016, 1:05 p.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46731/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 1:05 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-716 > https://issues.apache.org/jira/browse/ATLAS-716 > > > Repository: atlas > > > Description > ------- > > 1. Update/delete entity APIs return list of entities created, updated and > deleted > 2. Listeners are called for all the affected entities > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 104c0c5 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 813177f > > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java > ab7e6ee > client/src/main/java/org/apache/atlas/AtlasClient.java be34802 > client/src/main/java/org/apache/atlas/EntityAuditEvent.java 460f708 > client/src/main/java/org/apache/atlas/SerDe.java PRE-CREATION > client/src/main/java/org/apache/atlas/notification/EntityNotification.java > PRE-CREATION > > client/src/main/java/org/apache/atlas/notification/EntityNotificationImpl.java > PRE-CREATION > client/src/main/java/org/apache/atlas/notification/HookNotification.java > PRE-CREATION > client/src/test/java/org/apache/atlas/AtlasClientTest.java 8911bf5 > > client/src/test/java/org/apache/atlas/notification/EntityNotificationImplTest.java > PRE-CREATION > > client/src/test/java/org/apache/atlas/notification/HookNotificationTest.java > PRE-CREATION > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 68a868f > > notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java > 596f988 > > notification/src/main/java/org/apache/atlas/notification/AbstractNotificationConsumer.java > 1cadb99 > > notification/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 1f2df3e > > notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java > ac285aa > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java > 82a1100 > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java > fda588e > > notification/src/main/java/org/apache/atlas/notification/entity/NotificationEntityChangeListener.java > 300cbb5 > > notification/src/main/java/org/apache/atlas/notification/hook/HookNotification.java > 80c96fa > > notification/src/test/java/org/apache/atlas/notification/NotificationEntityChangeListenerTest.java > PRE-CREATION > > notification/src/test/java/org/apache/atlas/notification/entity/EntityNotificationImplTest.java > 385c41f > > notification/src/test/java/org/apache/atlas/notification/hook/HookNotificationTest.java > 57b0eea > pom.xml 729b178 > repository/pom.xml 533e48b > > repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java > 540c308 > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java > 5b4bdbf > > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java > 8f11322 > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > 369a5d5 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > de29e86 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > a3dc7e5 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 9f69940 > > repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java > be407a5 > > repository/src/test/java/org/apache/atlas/repository/audit/HBaseTestUtils.java > 84d7bab > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > ae215f9 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > 1f906ed > server-api/src/main/java/org/apache/atlas/RequestContext.java fa94763 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 13d20d8 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java > 31f157e > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 79b8124 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > b14aa80 > > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java > d6199ab > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java > 03a0d3f > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java > 54d8d92 > > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java > 720ce79 > webapp/src/test/java/org/apache/atlas/web/service/CuratorFactoryTest.java > 2d510a0 > > Diff: https://reviews.apache.org/r/46731/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > Shwetha GS > >
