-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45948/
-----------------------------------------------------------

(Updated May 13, 2016, 2:09 a.m.)


Review request for atlas.


Changes
-------

Addressed Shwetha's comments - inProcess set passed as argument rather than 
using thread local storage.


Bugs: ATLAS-645
    https://issues.apache.org/jira/browse/ATLAS-645


Repository: atlas


Description
-------

ATLAS-645: In FieldMapping.output(), avoid infinite recursion when 
IReferenceableInstance and IStruct instances reference each other.


Diffs (updated)
-----

  
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java
 31ef49d5e6accd8b4621385cce1e3a6b7a6936ff 
  
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java
 af62442bfe5daa221079207acf361e1316cab3ad 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/AbstractDataType.java
 92be3c794077bd3e437aa6f3426ed8b7892b945e 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 
e748579df8056994899624fac8e8a86958a27a6f 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 
90cf3ccfe8e9d0e20901452c0b83796ba3994998 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
55ec91f5c3cba65f1bf7c524c84c075cc1c96dff 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/FieldMapping.java 
36149bafff80b68ce176e82dcacac87035459362 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java
 89fcea6828c9e23c28a60952c3e4ca27c0667494 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/IDataType.java 
373ad2c93efdecc292b68fab1ea2403afce84dac 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 
a54dabc2f8366dbecc8372d81a48c741b2d65258 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 
54e344f5d6322a00ac7825ee8964f43a1552dcbe 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TraitType.java 
84c22bf96a059a78b065a73a8feefae87deb9975 
  
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java
 da246d66d94bcd3e221b70b859de2850fa6cf7a8 
  
typesystem/src/test/java/org/apache/atlas/typesystem/types/FieldMappingTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45948/diff/


Testing
-------

Ran all unit and integration tests with no regressions.  Added test cases


Thanks,

David Kantor

Reply via email to