[ 
https://issues.apache.org/jira/browse/ATLAS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284653#comment-15284653
 ] 

Hemanth Yamijala commented on ATLAS-491:
----------------------------------------

I have added most code review comments on the review board. Some comments are 
more design / requirements-ish. It seemed like adding those here is a better 
option:

* In general, with this patch we will now have two (not very well understood 
broadly) search methods. I consider this technical debt and needs to be cleared 
up.
* For the search part, this may conflict with work being done on ATLAS-692 and 
friends.
* Several questions on how the UI should behave:
** Which search method will currently be used by the UI for searching and 
adding terms.
** Can terms be added from the 'Add Tag' button of the entity page. If yes, the 
values like name and description and any other attributes of these terms will 
not be filled up which will be confusing to the user.
** The taxonomy entity shows up for every term search (as expected), Is this to 
be hidden?
** Something weird which I could not understand the behavior of: The taxonomy 
entity showed up the terms associated to it as tags (expected). I removed one 
of the associated terms. I thought by doing so, we would not be able to copy 
the attributes of this term when associating it to a different entity, but this 
worked. So, little bit confused about how.
* There are several TODOs in the code, some of which are important to fix as 
they have performance impacts. Please file these are follow-up jiras to fix in 
the 0.7 release. 

> Business Catalog / Taxonomy
> ---------------------------
>
>                 Key: ATLAS-491
>                 URL: https://issues.apache.org/jira/browse/ATLAS-491
>             Project: Atlas
>          Issue Type: New Feature
>    Affects Versions: 0.7-incubating
>            Reporter: Erik Bergenholtz
>            Assignee: John Speidel
>             Fix For: 0.7-incubating
>
>         Attachments: 
> 0001-ATLAS-491-Business-Catalog-API-changes-by-John-Speid.patch
>
>
> s a Atlas UX user, I need to:
> Browse business taxonomy hieracharlically through tree
> Search by Tags
> Search by combination of keyword, tag, free text in search field
> All search from view context of taxonomy. If 3 levels deep, then the search 
> should be narrow to that scope.
> expose search ordering capabilities available through SOLR.
> As a Data Steward, I need to:
> Manage the taxonomy of objects including
> Objects Management:
> Creating new objects
> Modify the object details - annotations, external links, tags, acceptable use 
> policy, etc
> Delete objects (in UI - changing status in backend,and versioning changes)
> Relationship management:
> creating relationship of objects as a parent or child
> assigning tagging to taxonomy
> verify tag inheritance
> Verify tag impact on tag based policy - ranger API call
> Tag Management:
> List
> Search
> Edit
> Delete (change state to archive)
> All user should be able to comment on any business catalog entity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to