-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46330/
-----------------------------------------------------------
(Updated May 19, 2016, 4:04 p.m.)
Review request for atlas, David Kantor and Hemanth Yamijala.
Changes
-------
Addressed remaining comments
Bugs: ATLAS-683
https://issues.apache.org/jira/browse/ATLAS-683
Repository: atlas
Description
-------
The local type-cache has been carved out as an interface ITypeCacheProvider and
the TypeSystem code has been refactored to use an instance of
ITypeCacheProvider injected through Guice. An instance of ITypeCacheProvider is
created by looking up the implementation class specified in
atlas-application.properties (property - atlas.typesystem.cache.provider). The
default implementation is a local cache implemented by DefaultTypeCacheProvider.
Diffs (updated)
-----
.gitignore f5899e2069d29d71378cabe51900c120db19eef9
common/src/main/java/org/apache/atlas/ApplicationProperties.java
6a4dca3cf15101dc239bc83b2e2eac7e3fdce4b3
distro/src/conf/atlas-application.properties
d4722fb6d8d3159673bffbe274dd52f938d5b9f7
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java
68b707f74e74c0a460d825d31f7c6f347dcba853
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java
7763ebc39593d2ba747bd53e861f1d35657c8ea1
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java
PRE-CREATION
typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/ITypeCacheProvider.java
PRE-CREATION
typesystem/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java
27f1f7e438d2516d0ac9fd68bfc4f563934a4842
typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java
c0574ce78d2df05015b33b1325ae3d0a1eb39218
typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProviderTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/46330/diff/
Testing
-------
Unit tests for the local cache DefaultTypeCacheProvider have been authored and
all other affected unit tests of TypeSystem interface are modified to function
in the presence of a type cache provider. Ran all tests of Atlas.
Thanks,
venkata madugundu
