----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47659/#review134309 -----------------------------------------------------------
dashboardv2/public/js/views/schema/SchemaLayoutView.js (line 126) <https://reviews.apache.org/r/47659/#comment199121> Sometimes the response of the API actually links to objects - for e.g. a hive_column links to a hive_table. These should be hyperlinked back to the object from the rows data. - Hemanth Yamijala On May 21, 2016, 10:47 a.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47659/ > ----------------------------------------------------------- > > (Updated May 21, 2016, 10:47 a.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, > and Hemanth Yamijala. > > > Bugs: ATLAS-817 > https://issues.apache.org/jira/browse/ATLAS-817 > > > Repository: atlas > > > Description > ------- > > **Patch contains following UI cleanup fixes : ** > 1) Font family changed to : Source Sans Pro > 2) Dynamically rendering schema table based on list that is received from > attributeDefinitions array. > 3) Made layout and looks of all tables same and consistent. > 4) Showing correct names for Terms (not showing parent Term's name in Term > name). > > > Diffs > ----- > > dashboardv2/public/css/login.css 3a88aa9 > dashboardv2/public/css/scss/main.scss 9ee1640 > dashboardv2/public/css/scss/override.scss 49f0810 > dashboardv2/public/css/scss/tab.scss 648e38d > dashboardv2/public/css/scss/tag.scss 74f768a > dashboardv2/public/css/scss/theme.scss 4d5b2d6 > dashboardv2/public/index.html 31e177f > dashboardv2/public/js/collection/VSchemaList.js cf22375 > dashboardv2/public/js/models/VCatalog.js 10ed835 > dashboardv2/public/js/router/Router.js b6a2edf > dashboardv2/public/js/templates/audit/CreateAuditTableLayoutView_tmpl.html > e193435 > dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html > 4184e8d > > dashboardv2/public/js/templates/entity/EntityDetailTableLayoutView_tmpl.html > 8ce71de > dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html > abbe593 > dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html 9bb10b8 > dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html > b444bf6 > dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html > a4a0928 > dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 39b6cec > dashboardv2/public/js/utils/CommonViewFunction.js 76941a6 > dashboardv2/public/js/utils/Utils.js 74cfb03 > dashboardv2/public/js/views/audit/AuditTableLayoutView.js e7754af > dashboardv2/public/js/views/business_catalog/BusinessCatalogLayoutView.js > 3136488 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js c35cfcf > dashboardv2/public/js/views/schema/SchemaLayoutView.js 7574367 > dashboardv2/public/js/views/search/SearchDetailLayoutView.js d32c01e > dashboardv2/public/js/views/tag/CreateTagLayoutView.js 186f26e > dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 421d5ad > dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 791d70b > dashboardv2/public/js/views/tag/TagLayoutView.js a89c692 > dashboardv2/public/js/views/tag/addTagModalView.js 2591a3f > > Diff: https://reviews.apache.org/r/47659/diff/ > > > Testing > ------- > > Ran : rat check. > > Verified Schema rendering on a Atlas setup which already had Entities > generated from Hive. > Verified all other UI improvements manually. > > > Thanks, > > keval bhatt > >
