[
https://issues.apache.org/jira/browse/ATLAS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299894#comment-15299894
]
Hemanth Yamijala commented on ATLAS-664:
----------------------------------------
Tested this patch on top of ATLAS-812 work-in-progress patch. Following are
some comments:
* The timestamp column is right aligned. Being a string, and being right
aligned makes it appear different from other string columns which are left
aligned. So it looks odd.
* For Tag add event, we don't show any details. The API is passing the added
tag in the audit response. This can be parsed and shown.
* In general, if there is a failure to parse any detail, it is better to show
the entry as a string, than not to show anything.
* A question: when do we parse the audit detail information - as part of the
received response, or when the 'details' button is clicked? Generally, I think
it is better if it is done when the details button is clicked, to enable fast
loading. Just wanted to check if that is what is happening.
* No pagination support. This can be taken in a separate JIRA, but needs to be
added.
* A usability suggestion. Would it be better to show the actions as "Added
entity", "Added tag", "Updated entity" instead of the technical looking
ENTITY_ADDED?
* One particular thing I found. I added a hive table and then executed a
command to add table properties to the table using the below commands:
{code}
create table products(id int, name string, category string);
alter table products set tblproperties ('contact'='[email protected]');
{code}
This was correctly captured as an entity update event, but when I clicked the
details of the event, it did not show the properties - still coming as null.
However, the property tab itself showed the values correctly. So, I think it is
a bug in the details parsing for audit.
Things that are working:
* Tested all operations - entity add / update / delete, tag add / delete - all
events showing correctly.
* User detail is coming correctly
* Entries are sorted in reverse order of timestamp
Looks good for a first cut. If the above set of comments can be addressed
(without pagination), can commit this after ATLAS-812 goes in.
> UI: Add Support for Versioning / History
> ----------------------------------------
>
> Key: ATLAS-664
> URL: https://issues.apache.org/jira/browse/ATLAS-664
> Project: Atlas
> Issue Type: Improvement
> Affects Versions: 0.7-incubating
> Reporter: Erik Bergenholtz
> Assignee: Kalyani Kashikar
> Fix For: 0.7-incubating
>
> Attachments: ATLAS-664.patch
>
>
> ATLAS-540 adds REST API support for fetching information about changes to
> entities stored in Atlas (this is being referred to as versioning). For each
> detailed page in Atlas, we need to expose the information provided by the
> REST API in tabular format.
> It makes sense to create a separate tab (next to "tags") on the entity
> detailed page where this information is displayed.
> The API is straightforward and can be accessed by {guid}/audit
> For more information see:
> https://github.com/apache/incubator-atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java#L612
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
