----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47898/#review135170 -----------------------------------------------------------
catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java (line 102) <https://reviews.apache.org/r/47898/#comment200188> Do we need this call? The call to deleteTag seems to be throwing an EntityNotFoundException if the entity is not found. That can be caught and handled. This will help avoid an additional lookup call to the entity. - Hemanth Yamijala On May 26, 2016, 3:52 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47898/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 3:52 p.m.) > > > Review request for atlas and Hemanth Yamijala. > > > Bugs: ATLAS-793 > https://issues.apache.org/jira/browse/ATLAS-793 > > > Repository: atlas > > > Description > ------- > > Provide support for deletion of taxonomies, terms and tags > > > Diffs > ----- > > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 6f2e0be > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java f3376b0 > catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java > 517eaf6 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > f71c061 > > catalog/src/main/java/org/apache/atlas/catalog/EntityTagResourceProvider.java > dc4ab0d > catalog/src/main/java/org/apache/atlas/catalog/ResourceProvider.java > 4c4319c > > catalog/src/main/java/org/apache/atlas/catalog/TaxonomyResourceProvider.java > 7a46f5d > catalog/src/main/java/org/apache/atlas/catalog/TermResourceProvider.java > 431b06d > catalog/src/main/java/org/apache/atlas/catalog/projection/BaseRelation.java > PRE-CREATION > > catalog/src/main/java/org/apache/atlas/catalog/projection/GenericRelation.java > 5f59bea > catalog/src/main/java/org/apache/atlas/catalog/projection/TagRelation.java > a5e15c6 > > catalog/src/main/java/org/apache/atlas/catalog/projection/TraitRelation.java > 5f11474 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityQuery.java > e2bc597 > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasEntityTagQuery.java > 013bb8a > > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTaxonomyQuery.java > 787f734 > catalog/src/main/java/org/apache/atlas/catalog/query/AtlasTermQuery.java > 0065101 > catalog/src/main/java/org/apache/atlas/catalog/query/BaseQuery.java c2eabf7 > > catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java > a95b966 > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > 9cf3d12 > > catalog/src/test/java/org/apache/atlas/catalog/TermResourceProviderTest.java > 34222ca > > catalog/src/test/java/org/apache/atlas/catalog/projection/TagRelationTest.java > PRE-CREATION > > catalog/src/test/java/org/apache/atlas/catalog/query/AtlasEntityQueryTest.java > 838d4c1 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 6bca3df > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java > 3982df8 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > 0e3f4c4 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > ccd0b62 > > Diff: https://reviews.apache.org/r/47898/diff/ > > > Testing > ------- > > - Added new unit tests > - Ran all existing unit tests > - Manual functional testing of all new functionality > > > Thanks, > > John Speidel > >
