-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47466/
-----------------------------------------------------------
(Updated June 10, 2016, 3:48 p.m.)
Review request for atlas and David Kantor.
Changes
-------
Fixed build issue in webapp.
Bugs: ATLAS-693
https://issues.apache.org/jira/browse/ATLAS-693
Repository: atlas
Description
-------
Adding titan 0.5.4 implementation of abstraction layer under graphdb/titan0.
The original TitanGraphProvider class has been morphed into Titan0Database in
this new project. This class has the logic that configures Titan and loads the
graph. A new TitanGraphProvider has been introduced in atlas-repository that
delegates everything to Titan0Database. Now, the TitanGraph is being
initialized using the code in the new abstraction layer implementation. In
addition, the atlas-titan project has been merged into graphdb/titan0. This
consolidates all of the titan 0.5.4 configuration logic into the new project.
All dependencies on atlas-titan have been replaced with dependencies on
atlas-graphdb-titan0. The Atlas war now bundles atlas-graphdb-api and
atlas-graphdb-titan0. At this point, though, Atlas is still not using the
abstraction layer classes (AtlasVertex, AtlasEdge, etc) at runtime. It is
still hard-coded to use the Titan 0.5.4 classes. The only logic in the
abstraction layer
implementation that is actually being used is the logic to configure Titan
and create a TitanGraph.
Also added "solr" as a supported key for the solr index. This is the key that
is used for the index in Titan 1.0.0 (which has solr support built-in). solr5
is still allowed for backward compatibility, but this allows more consistency
between the implementations and simplifies the test setup logic in the pom.xmls
(we will need to update fewer properties when testing titan 1.0.0).
Diffs (updated)
-----
distro/src/bin/atlas_start.py bb6189886fe34e7e4496b521cd5cae62df492e36
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdge.java
71b577b5c2e8aee8fec816b9224672ebc2cad5b3
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasEdgeDirection.java
e7da1c9a5075004973ba68b8a36a2c95756e0e62
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasElement.java
3c41693e531eb523f04a5c5781f1f123ab38ef07
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java
f312117af9cb6ae8de21d565bfcf3b10d9bdfcc6
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphIndex.java
PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
2776b2242c4469dcae344616ccfe100633a79432
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
f0dca9a28eebd8996d55d71dcc3254cce9cd4098
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
7ee6b2831a7610e7d5b1d36ae69282a9315dc06b
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasPropertyKey.java
PRE-CREATION
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasSchemaViolationException.java
fda83b807f3640c04a660001941376f41be6d9be
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertex.java
e027b6962cf27a8c2dfbbf6fcc9683fa19e00ae5
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
fd20a6524c4795b4212599c2f4ced69c2bbf14c0
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java
a608eb27921d4be44e639f773ace818115f39ff2
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GremlinVersion.java
e817cba200c6d3c4c593b242cb2317e141bab570
graphdb/pom.xml 666fe5a01e55d7b761d391e3ef6172f769488254
graphdb/titan0/pom.xml PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/GraphDbObjectFactory.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseManager.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Edge.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Element.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphQuery.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0PropertyKey.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/TitanObjectFactory.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/utils/EdgeToAtlasEdgeFunction.java
PRE-CREATION
graphdb/titan0/src/main/java/org/apache/atlas/utils/VertexToAtlasVertexFunction.java
PRE-CREATION
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java
PRE-CREATION
graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseValidationTest.java
PRE-CREATION
graphdb/titan0/src/test/resources/atlas-application.properties PRE-CREATION
pom.xml e13345e81ce73206ec8d800139838bf63ea63534
repository/pom.xml 533e48b8dbf8f1d80903b804ddc7da9818fe6702
repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java
c4c767827014a265471250306f35316a0b4ed67f
repository/src/main/java/org/apache/atlas/repository/Constants.java
893f1b64fa5d38c8025e6faf86335864f77d1439
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
4f6d0118072380342f5ea302d0aaf7902784849a
repository/src/main/java/org/apache/atlas/repository/graph/TitanGraphProvider.java
2cc1a50e2ea139c3a462c918b94945fff602cf17
repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala
5a64c53bdb94174bf5699d9e034960f42450f696
repository/src/test/java/org/apache/atlas/repository/graph/TitanGraphProviderTest.java
6fc700823800eaa943a34afecb2c2e6fba50637a
src/build/checkstyle-suppressions.xml
0025360552a32ffa0a5aa5696f27921a4752513f
titan/pom.xml 09006d9dd5e21aa24f53524aa42a3fcd6f3d9fe6
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/AdminMask.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/ConnectionMask.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin0_98.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseAdmin1_0.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat0_98.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_0.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat1_1.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseTransaction.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection0_98.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HConnection1_0.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable0_98.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HTable1_0.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/TableMask.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java
titan/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java
titan/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java
webapp/pom.xml cce6dd6f073b15732d2aa5d26fd4aed090ddf65d
Diff: https://reviews.apache.org/r/47466/diff/
Testing
-------
Ran all atlas unit/integration tests, no regressions found. Addded tests for
new code.
Thanks,
Jeff Hagelberg
