----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48280/#review137355 -----------------------------------------------------------
Ship it! Ship It! - Suma Shivaprasad On June 13, 2016, 4:35 p.m., Hemanth Yamijala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48280/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 4:35 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-515 > https://issues.apache.org/jira/browse/ATLAS-515 > > > Repository: atlas > > > Description > ------- > > Attached patch provides a method to automatically create Kafka topics > ATLAS_HOOK and ATLAS_ENTITIES with configured number of replicas. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 3dbab17 > distro/src/bin/atlas_client_cmdline.py f109ad3 > distro/src/bin/atlas_config.py fab4046 > distro/src/bin/atlas_kafka_setup.py PRE-CREATION > distro/src/bin/atlas_kafka_setup_hook.py PRE-CREATION > distro/src/conf/atlas-application.properties 2b90086 > distro/src/main/assemblies/standalone-package.xml 1c7b2c5 > docs/src/site/twiki/Configuration.twiki 7150483 > docs/src/site/twiki/InstallationSteps.twiki 518c380 > notification/pom.xml b3738db > notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java > PRE-CREATION > notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java > PRE-CREATION > pom.xml e13345e > > Diff: https://reviews.apache.org/r/48280/diff/ > > > Testing > ------- > > * Started multiple Kafka brokers on single machine, configured number of > replicas to be 2, started Atlas server and verified they got created > correctly. > * Started multiple Kafka brokers on single machine, configured number of > replicas to be 2, started Hive hook and verified it created ATLAS_HOOK > correctly. Then started Atlas server and verified it by-passed ATLAS_HOOK > creation, but did ATLAS_ENTITIES creation. > * Started one Kafka broker, onfigured number of replicas to be 2, started > Atlas server and verified it received an exception as expected. But topic > could still get auto-created and continued. > * Started 2 instances of Atlas server concurrently and verified topic > creation is working fine. > * Existing UTs/ITs/new UTs pass. > > > Thanks, > > Hemanth Yamijala > >
