> On June 9, 2016, 11:30 a.m., Shwetha GS wrote: > > The following tests failed for me with this patch. Did they work for you? > > Failed tests: > > > > HiveHookIT.testAlterTablePartitionColumnType:911->assertColumnIsRegistered:276->assertEntityIsRegistered:1498->waitFor:1591 > > Assertions failed. Failing after waiting for timeout 80000 msecs > > > > HiveHookIT.testAlterTableRename:659->assertColumnIsRegistered:271->assertColumnIsRegistered:276->assertEntityIsRegistered:1498->waitFor:1591 > > Assertions failed. Failing after waiting for timeout 80000 msecs > > > > Tests run: 43, Failures: 2, Errors: 0, Skipped: 0 > > David Kantor wrote: > I am getting this test failure, will investigate. > > David Kantor wrote: > I have investigated the test failures, and they are being caused by lock > timeouts that are causing entity updates applied by the > NotificationHookConsumer to fail, so the test fails to find the expected > updated entity within 80000 msec. This looks similar to the issue raised in > https://issues.apache.org/jira/browse/ATLAS-759. It appears that the > addition of updating the reverse reference is causing more contention on > berkeley db locks between Jersey threads reading the data on behalf of the > test vs NotificationHookConsumer threads writing the data. The default lock > timeout for berkeley db is only 500ms which seems pretty small. The question > is whether the increased berkeley db lock contention is exposing a problem > with my changes or with the test design. Another question is whether this is > an issue when running on HBase. Thoughts?
In these tests, you can try if replacing runCommand() with runCommandWithDelay() will help - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47658/#review136791 ----------------------------------------------------------- On June 6, 2016, 10:53 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47658/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 10:53 p.m.) > > > Review request for atlas and Shwetha GS. > > > Bugs: ATLAS-499 > https://issues.apache.org/jira/browse/ATLAS-499 > > > Repository: atlas > > > Description > ------- > > ATLAS-499: Automatically update inverse references to prevent repository > corruption from unbalanced references. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > 91f9bd008a6939dfe78656f5c1845637a30ee9eb > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 4f6d0118072380342f5ea302d0aaf7902784849a > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > 4c1f5591f4adead41c3336e64b0bc956836f7edb > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > 449e066a167ba4546b118a77c8e3de5fd99f077b > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateHardDeleteTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateSoftDeleteTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47658/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >
