[ 
https://issues.apache.org/jira/browse/ATLAS-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333131#comment-15333131
 ] 

Madhan Neethiraj commented on ATLAS-901:
----------------------------------------

[~yhemanth] it will be easier to review if the patch is available in the review 
board.

bq. +                        logger.log(((NotificationException) 
e).getFailedMessage());
if 'messages' contain multiple messages, notification processing seems to stop 
at the first failure (in KafkaNotification.java). Above logging only writes the 
failed message; subsequent message in the list will be lost. Consider 
NotificationException to store list of messages not sent; and update above 
logging to write all these messages.


> Log messages that cannot be sent to Kafka to a specific log configuration
> -------------------------------------------------------------------------
>
>                 Key: ATLAS-901
>                 URL: https://issues.apache.org/jira/browse/ATLAS-901
>             Project: Atlas
>          Issue Type: Bug
>    Affects Versions: 0.7-incubating
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-901.patch
>
>
> In ATLAS-801, we considered the topic of what to do when Atlas hooks cannot 
> send notifications to Kafka for an extended period of time. For providing a 
> tactical alternative in the shorter term, this JIRA is looking to make the 
> logging of these messages in such a way that they are separate and easy to 
> manage on machines where the failures occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to