----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48837/ -----------------------------------------------------------
Review request for atlas. Bugs: ATLAS-911 https://issues.apache.org/jira/browse/ATLAS-911 Repository: atlas Description ------- Currently, get entity by unique attribute just filters on the attribute property. Since the attribute name contains the typename as well, type filter was not added. But if multiple types have the same super type, and the super type has the unique attribute, the attribute name will be same for multiple types. With this, the type returned will not be same as the type requested. We should add filter on the type as well Diffs ----- repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 0d82d90 repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 4f6d011 repository/src/test/java/org/apache/atlas/TestUtils.java 345e874 repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java 5e7de88 repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 449e066 repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 2d1c33a Diff: https://reviews.apache.org/r/48837/diff/ Testing ------- UTs Thanks, Shwetha GS