> On June 17, 2016, 12:03 p.m., Hemanth Yamijala wrote: > > addons/storm-bridge/pom.xml, line 102 > > <https://reviews.apache.org/r/48845/diff/2/?file=1422190#file1422190line102> > > > > Why this change? These dependency changes might need to be tested in > > the host component environments. Also, I see we have a dependency exclusion > > when specifying storm dependency pointing to slf4j-log4j12, should that > > change?
slf4j-log4j12 and log4j-over-slf4j can't both co-exist. The build was failing because of that. Since we already depend on slf4j-log4j12, we have to exclude log4j-over-slf4j. Not sure why this didn't come up earlier. Will revert for now and check - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48845/#review138203 ----------------------------------------------------------- On June 17, 2016, 10:47 a.m., Shwetha GS wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48845/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 10:47 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-835 > https://issues.apache.org/jira/browse/ATLAS-835 > > > Repository: atlas > > > Description > ------- > > Falcon Integration with Atlas > > > Diffs > ----- > > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/Util/EventUtil.java > PRE-CREATION > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java > PRE-CREATION > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java > PRE-CREATION > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java > f27a8b0 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataModelGenerator.java > 397dea4 > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/model/FalconDataTypes.java > f1f350b > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/publisher/FalconEventPublisher.java > PRE-CREATION > > addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/service/AtlasService.java > PRE-CREATION > > addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/Util/EventUtil.java > 7f67407 > > addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/event/FalconEvent.java > e587e73 > > addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/publisher/FalconEventPublisher.java > 8029be9 > > addons/falcon-bridge/src/main/java/org/apache/falcon/atlas/service/AtlasService.java > 373846d > > addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java > 7adccef > addons/falcon-bridge/src/test/resources/feed-replication.xml PRE-CREATION > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > 0ccb18b > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 00c17e8 > addons/storm-bridge/pom.xml b1a7a9b > distro/src/conf/atlas-log4j.xml 600b4f1 > docs/src/site/twiki/Bridge-Falcon.twiki 4f5e676 > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 2ca8d85 > pom.xml 6f75740 > typesystem/src/main/resources/atlas-application.properties 11253e6 > typesystem/src/main/resources/atlas-log4j.xml 2bb49d3 > webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java eeaddd6 > > Diff: https://reviews.apache.org/r/48845/diff/ > > > Testing > ------- > > UTs and end to end test > > > Thanks, > > Shwetha GS > >
