> On June 21, 2016, 8:49 a.m., Shwetha GS wrote: > > repository/src/test/resources/org/apache/atlas/repository/typestore/atlas-application.properties, > > line 2 > > <https://reviews.apache.org/r/48565/diff/3/?file=1425756#file1425756line2> > > > > is there any way we can avoid having a copy of > > atlas-application.properties here?
I'm not sure how to avoid this given the current Atlas configuration mechanism. I have added tests that depend on StoreBackedTypeCache being configured as the TypeCache implementation class in atlas-application.properties. Other than using the atlas.conf system property to point ApplicationProperties at a directory which contains a properties file that has the setting needed for the tests, I don't see another way of overriding the default value of the atlas.TypeCache.impl property. I suppose we could enhance ApplicationProperties to support overriding the configured value with a system property of the same name. Is your main concern to avoid the proliferation of test versions of atlas-application.properties? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48565/#review138785 ----------------------------------------------------------- On June 20, 2016, 9:57 p.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48565/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 9:57 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-856 > https://issues.apache.org/jira/browse/ATLAS-856 > > > Repository: atlas > > > Description > ------- > > ATLAS-856: Implemented StoreBackedTypeCache, an extension of DefaultTypeCache > which loads the requested type from the type store if it is not found in the > cache, and adds it to the cache if it's found in the store. Any attribute > and super types that are required by the requested type are also loaded from > the store if they are not already in the cache. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > c4c767827014a265471250306f35316a0b4ed67f > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 5ed9e02eb85ec25b63540cab40d148914d410786 > > repository/src/main/java/org/apache/atlas/repository/typestore/ITypeStore.java > 790c4b31c37e51289585f6f891366a8d8c86b168 > > repository/src/main/java/org/apache/atlas/repository/typestore/StoreBackedTypeCache.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > d9e6cb9e9243c4d53808089efeaaaf1329561df3 > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > 961442bbcaff86b472a876e6c348aa9e65c1efca > > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheConfigurationTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTestModule.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/service/StoreBackedTypeCacheMetadataServiceTest.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/services/DefaultMetadataServiceMockTest.java > effee2a43d8c1e1369b52f1c3899cb882ea52aa1 > > repository/src/test/resources/org/apache/atlas/repository/typestore/atlas-application.properties > PRE-CREATION > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > 14f1968c2dd6765793c1c43e3ea1ed5f3a9c8a42 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProvider.java > 700bda6463e039b8f6ad2ac75840f9e637a883b0 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/ITypeCacheProvider.java > 55e9ddc463c748d3cd631d11860235dbe1a92714 > > typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheProviderTest.java > c426d50f52dfd99835d9fcf1c6f95841ba4b5494 > > Diff: https://reviews.apache.org/r/48565/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >
