----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49357/#review139962 -----------------------------------------------------------
1. Remove glyphicons files 2. Add licenses in LICENSE in this format: This product bundles Font Awesome <version> which is available under a SIL Open Font License (OFL). For details, see 3party-licenses/SILOFL-LICENSE (replace version) 3. Add apache headers in all .scss files in dashboardv2/public/css/scss. Its in style.scss, but not others - Shwetha GS On June 29, 2016, 7:43 a.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49357/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 7:43 a.m.) > > > Review request for atlas, Gautam Borad, Madhan Neethiraj, Shwetha GS, and > Hemanth Yamijala. > > > Bugs: ATLAS-958 > https://issues.apache.org/jira/browse/ATLAS-958 > > > Repository: atlas > > > Description > ------- > > Patch include following changes. > > * Removed unused font (glyphicon) > * Added licence file to all js libraries (added grunt task to copy license > file to dist folder) > * Added all libraries license details in {atlas_home}/LICENSE.txt file > * Removed unused plugin (tree.js) > > > Diffs > ----- > > LICENSE 8f075f5 > dashboardv2/gruntfile.js 2f30f3b > dashboardv2/public/js/main.js 95f64a1 > dashboardv2/public/js/views/business_catalog/MoveTermLayoutView.js 3add56a > dashboardv2/public/js/views/search/SearchLayoutView.js 083e515 > > Diff: https://reviews.apache.org/r/49357/diff/ > > > Testing > ------- > > After removing glyphicon --> did manual testing of UI using users of all 3 > groups. > > Did CRUD operations for Terms, Tags and verified Lineage graph generation > using hive queries. > > > Thanks, > > keval bhatt > >
