----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49350/#review139964 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 746) <https://reviews.apache.org/r/49350/#comment205304> There is only one {}, but two arguments. So, the 2nd argument will not be logged addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 782) <https://reviews.apache.org/r/49350/#comment205327> The loop is over inputs, so the input qualified table names that are added to qualified name are not sorted anymore. addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java (line 790) <https://reviews.apache.org/r/49350/#comment205325> We are not adding hdfs paths in qualified name for partitioned tables, but we add it to inputs for lineage. With process update, lineage will get updated, right? - Shwetha GS On June 29, 2016, 4:41 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49350/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 4:41 a.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > this is added for LOAD, IMPORT, EXPORT . Could not add to INSERT OVERWRITE > hdfs paths due to some hive issues which does not provide partition related > information in this case. That will continue to work as earlier. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 0045780 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > a1a00b3 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > f9e1926 > notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 8bbe2d7 > > Diff: https://reviews.apache.org/r/49350/diff/ > > > Testing > ------- > > Added tests for partitioned and unpartitioned export, import, load > > > Thanks, > > Suma Shivaprasad > >
