----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49636/#review141134 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java (line 516) <https://reviews.apache.org/r/49636/#comment206547> Remove this and other info logs in the method. - Madhan Neethiraj On July 5, 2016, 2:25 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49636/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 2:25 p.m.) > > > Review request for atlas, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma > Shivaprasad, and Hemanth Yamijala. > > > Bugs: ATLAS-990 > https://issues.apache.org/jira/browse/ATLAS-990 > > > Repository: atlas > > > Description > ------- > > Changes include fix for authentication failing while hive import script. > > The getToken method was throwing nullpointer exception, so overriden the > getToken method and added NPE check do fix it. > > 2016-07-04 14:13:58,946 ERROR - [qtp817406040-17:] ~ Exception in > AtlasAuthenticationFilter (AtlasAuthenticationFilter:304) > java.lang.NullPointerException > at > org.apache.hadoop.security.authentication.server.AuthenticationFilter.getToken(AuthenticationFilter.java:480) > at > org.apache.atlas.web.filters.AtlasAuthenticationFilter.doKerberosAuth(AtlasAuthenticationFilter.java:339) > at > org.apache.atlas.web.filters.AtlasAuthenticationFilter.doFilter(AtlasAuthenticationFilter.java:299) > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/security/SecureClientUtils.java > 1686112 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > 1b70e9b > > Diff: https://reviews.apache.org/r/49636/diff/ > > > Testing > ------- > > Ran Quick start after kinit and worked fine and example data was populated. > Ran import hive script after kinit and hive tables schema details was seen. > Browsed Atlas UI with fqdn url in firefox after kinit without going through > login page. > > Instance http://172.22.107.229:8080/ > > > Thanks, > > Nixon Rodrigues > >
