-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49633/
-----------------------------------------------------------

(Updated July 7, 2016, 10:15 a.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and 
Hemanth Yamijala.


Changes
-------

Rebased patch by resolving the conflict (no new feature has been added).


Bugs: ATLAS-949
    https://issues.apache.org/jira/browse/ATLAS-949


Repository: atlas


Description
-------

* Style change for Tag.
* Popup(Modal) beautify for assign term to Asset from search table and same for 
schema.
* In table by default only one tag is shown and if there are more Tags they are 
shown by "..." button insted of "Show more" - "Show less" button.
* UI(Modal) changes for Add tag.
* Text change from "delete" to "remove" in assign term/tag Modal.


Diffs (updated)
-----

  dashboardv2/public/css/scss/main.scss 6b88639 
  dashboardv2/public/css/scss/tag.scss 8eb0ac2 
  dashboardv2/public/css/scss/tree.scss 5574137 
  dashboardv2/public/js/collection/BaseCollection.js e4ac1ae 
  dashboardv2/public/js/collection/VCatalogList.js 410a35a 
  
dashboardv2/public/js/templates/business_catalog/BusinessCatalogDetailLayoutView_tmpl.html
 5e1cfca 
  dashboardv2/public/js/templates/business_catalog/TreeLayoutView_tmpl.html 
b915680 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
f638bac 
  dashboardv2/public/js/templates/search/SearchDetailLayoutView_tmpl.html 
3fd1b7a 
  dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 2aa82f6 
  dashboardv2/public/js/utils/CommonViewFunction.js 6d88dc8 
  dashboardv2/public/js/utils/Messages.js f78ec87 
  dashboardv2/public/js/utils/Utils.js 5e75e59 
  
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js 
7e3e586 
  dashboardv2/public/js/views/business_catalog/TreeLayoutView.js 63eaa3e 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7f31141 
  dashboardv2/public/js/views/graph/LineageLayoutView.js ecbbe51 
  dashboardv2/public/js/views/schema/SchemaLayoutView.js 55e7093 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 75bf6ef 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js e9d4b57 
  dashboardv2/public/js/views/tag/addTagModalView.js 58f4918 

Diff: https://reviews.apache.org/r/49633/diff/


Testing
-------

Ran Quick start and did sanity test for tags / entity / lineage UI.

** Verified following scenarios:**

* Tags UI shown properly.
* UI of modal for assign term to Asset from search table/ schema table  and Add 
tag shown properly.
* In table by default only one tag is shown and if there are more Tags they are 
shown by "..." button insted of "Show more" - "Show less" button - verified 
this case.
* Text changed from "delete" to "remove" in assign term/tag Modal- verified.


Thanks,

Kalyani Kashikar

Reply via email to