----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49753/#review141160 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 7, 2016, 12:47 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49753/ > ----------------------------------------------------------- > > (Updated July 7, 2016, 12:47 p.m.) > > > Review request for atlas, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma > Shivaprasad, and Hemanth Yamijala. > > > Bugs: ATLAS-995 > https://issues.apache.org/jira/browse/ATLAS-995 > > > Repository: atlas > > > Description > ------- > > Currently in Atlas atlas.authentication.method.ldap=false/true and > atlas.authentication.method.ldap.type=LDAP /AD properties are needed to > configure ldap authentication. > The proposed change configures ldap authentication in single property > atlas.authentication.method.ldap.type=LDAP /AD or None hence it become easy > to configure via Ambari UI. > > The patch includes changes to remove property > atlas.authentication.method.ldap and None as default value to > atlas.authentication.method.ldap.type property instead setting > atlas.authentication.method.ldap=false. > > > Diffs > ----- > > distro/src/conf/atlas-application.properties e50d6b9 > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java > 7780191 > > Diff: https://reviews.apache.org/r/49753/diff/ > > > Testing > ------- > > Tested LDAP/AD authentication logins after setting respective values to > property atlas.authentication.method.ldap.type. > Tested fallback to file authentication when ldap/Ad fails. > Tested file authentication when atlas.authentication.method.ldap.type is set > to None. > > > Thanks, > > Nixon Rodrigues > >
