----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49570/#review142004 -----------------------------------------------------------
catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java (line 209) <https://reviews.apache.org/r/49570/#comment207483> Instead of adding a supertype, lets just add the attribute directly. We need to support migration path for future versions. Adding an optional attribute is supported, but not adding a supertype common/src/main/java/org/apache/atlas/AtlasConstants.java (line 36) <https://reviews.apache.org/r/49570/#comment207482> Move these constants to catalog module Rename to taxonomy.namespace so that it doesn't conflict with namespace that we might add to all entities/types in future typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java (line 19) <https://reviews.apache.org/r/49570/#comment207461> revert, no changes? - Shwetha GS On July 3, 2016, 7:21 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49570/ > ----------------------------------------------------------- > > (Updated July 3, 2016, 7:21 a.m.) > > > Review request for atlas and Suma Shivaprasad. > > > Bugs: ATLAS-986 > https://issues.apache.org/jira/browse/ATLAS-986 > > > Repository: atlas > > > Description > ------- > > Ability to differentiate business catalog terms from traits (author: > suma.shivaprasad) > > > Diffs > ----- > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 8ca47d9 > catalog/pom.xml 7b9b691 > catalog/src/main/java/org/apache/atlas/catalog/AtlasTypeSystem.java 3a58488 > catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java > a8e63f3 > > catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java > ff22f3b > catalog/src/test/java/org/apache/atlas/catalog/DefaultTypeSystemTest.java > PRE-CREATION > > catalog/src/test/java/org/apache/atlas/catalog/TaxonomyResourceProviderTest.java > 5a03414 > > catalog/src/test/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinitionTest.java > 33620c3 > common/src/main/java/org/apache/atlas/AtlasConstants.java cb46316 > pom.xml f119525 > repository/pom.xml 9c34f19 > > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java > 99f0036 > repository/src/test/java/org/apache/atlas/TestUtils.java a159496 > > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java > e6dd230 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > 7cc036c > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java > c355ba9 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java > 1f0c944 > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java > d84f8a2 > > webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java > b2ff4cf > > Diff: https://reviews.apache.org/r/49570/diff/ > > > Testing > ------- > > > Thanks, > > Madhan Neethiraj > >
