----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49941/#review142364 -----------------------------------------------------------
Fix it, then Ship it! Minor comments. Will fix and commit. Thanks common/src/test/java/org/apache/atlas/ha/HAConfigurationTest.java (line 76) <https://reviews.apache.org/r/49941/#comment207940> Add test which checks if haenabled=true when ha.configuration is not set and ids is set repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryHATest.java (line 58) <https://reviews.apache.org/r/49941/#comment207941> The changes in these tests not required. revert? - Shwetha GS On July 13, 2016, 2:59 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49941/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 2:59 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-998 > https://issues.apache.org/jira/browse/ATLAS-998 > > > Repository: atlas > > > Description > ------- > > Updated to use atlas.server.ids property to determine if multiple instances > of Atlas are configured to run (in HA mode), instead of > atlas.server.ha.enabled > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/ha/HAConfiguration.java f3c9bc5 > common/src/test/java/org/apache/atlas/ha/HAConfigurationTest.java a3129c9 > > repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryHATest.java > 2f7edb4 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java > 94dd298 > > repository/src/test/java/org/apache/atlas/services/DefaultMetadataServiceMockTest.java > 393b539 > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java > 7860eb6 > > webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java > 2b7691f > webapp/src/test/java/org/apache/atlas/web/service/ServiceStateTest.java > 77aba88 > > Diff: https://reviews.apache.org/r/49941/diff/ > > > Testing > ------- > > - Verified that all unit tests succeed > - Verified that when multiple instances are listed in 'atlas.server.ids' > configuration, Atlas server takes HA code path > > > Thanks, > > Madhan Neethiraj > >
