-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50149/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1030
    https://issues.apache.org/jira/browse/ATLAS-1030


Repository: atlas


Description
-------

Added instrumentation to measure performance of REST APIs


Diffs
-----

  common/src/main/java/org/apache/atlas/utils/AtlasPerfTracer.java PRE-CREATION 
  distro/src/conf/atlas-log4j.xml 30e88f8 
  typesystem/src/main/resources/atlas-log4j.xml 1225db2 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
5dcf21c 
  
webapp/src/main/java/org/apache/atlas/web/resources/DataSetLineageResource.java 
bb7fe46 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
21ed04f 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java 
f7b32b6 
  webapp/src/main/java/org/apache/atlas/web/resources/LineageResource.java 
7c92c33 
  
webapp/src/main/java/org/apache/atlas/web/resources/MetadataDiscoveryResource.java
 3f22217 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 
3c460ed 
  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 
d105c1e 

Diff: https://reviews.apache.org/r/50149/diff/


Testing
-------

Verified that the instrumentation generates performance traces of format 
"datetime|thread-id|PERF|method(params)|timeTakenInMs", as given below:
2016-07-18 10:24:56,693|qtp21257599-19 - 
be2b8c39-125f-4047-91c8-aef64309d481|PERF|AdminResource.getStatus()|2
2016-07-18 10:26:28,664|qtp21257599-81 - 
2b919758-e455-4f7f-9194-ac5e089dc09c|PERF|AdminResource.getUserProfile()|3
2016-07-18 10:26:28,947|qtp21257599-79 - 
0c846820-96f1-498d-bb87-a05b1882a5f8|PERF|TypesResource.getDefinition(PII)|144
2016-07-18 10:26:30,464|qtp21257599-20 - 
a1f185e3-3400-46a1-8025-b2a56c67ad40|PERF|MetadataDiscoveryResource.search(PII)|1667
2016-07-18 10:26:30,873|qtp21257599-79 - 
afea8d79-c23f-4eb9-8084-d8a6b1b987e7|PERF|EntityResource.getEntityDefinition()|366
2016-07-18 10:27:02,963|qtp21257599-20 - 
0850ea5e-02ed-467c-adb3-7bb7260112b7|PERF|MetadataDiscoveryResource.searchUsingQueryDSL(hive_table)|892
2016-07-18 10:27:18,347|qtp21257599-79 - 
c4b1611d-4659-4174-8712-861249c2512a|PERF|EntityResource.getEntityDefinition()|41
2016-07-18 10:27:18,651|qtp21257599-21 - 
02449c7e-c210-46a6-9406-5d5b7e67b136|PERF|EntityResource.getAuditEvents(4cbe8e2a-9d24-499f-b1a2-18bdc244001b,
 null, 25)|209
2016-07-18 10:27:19,417|qtp21257599-17 - 
808e636e-2f97-446c-a0c1-2fc74ea20278|PERF|LineageResource.schema(4cbe8e2a-9d24-499f-b1a2-18bdc244001b)|966
2016-07-18 10:27:20,000|qtp21257599-22 - 
2be62229-51a5-4062-b675-98873e456241|PERF|LineageResource.inputsGraph(4cbe8e2a-9d24-499f-b1a2-18bdc244001b)|1573
2016-07-18 10:27:21,125|qtp21257599-19 - 
d6b44fa9-6a48-4662-bebb-3da7dd247c06|PERF|LineageResource.outputsGraph(4cbe8e2a-9d24-499f-b1a2-18bdc244001b)|1114
2016-07-18 10:30:58,316|qtp21257599-20 - 
2ca1e1b8-c7b1-45a2-90ee-77ea05d839a6|PERF|AdminResource.getStatus()|1


Thanks,

Madhan Neethiraj

Reply via email to