> On Aug. 4, 2016, 3:12 a.m., Arun Mahadevan wrote: > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java, > > line 140 > > <https://reviews.apache.org/r/50776/diff/2/?file=1462267#file1462267line140> > > > > Minor: this line can be removed.
Good suggestion. Thanks Arun. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50776/#review144705 ----------------------------------------------------------- On Aug. 4, 2016, 4:29 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50776/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 4:29 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1089 > https://issues.apache.org/jira/browse/ATLAS-1089 > > > Repository: atlas > > > Description > ------- > > Updated Storm hook to handle cyclic references in Storm topology object > > > Diffs > ----- > > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java > c4b4976 > > addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java > ce6a175 > > Diff: https://reviews.apache.org/r/50776/diff/ > > > Testing > ------- > > Validated that Atlas Storm hook gracefully handles cyclic references in Storm > topology object, using a test topology implementation. > > > Thanks, > > Madhan Neethiraj > >
