----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49869/#review144724 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 442) <https://reviews.apache.org/r/49869/#comment210793> This has to be a set to make sure there are no duplicates. The loop later can exit if already added to set. Instead of adding multiple data structures here, just stack<vertex> and set<vertex> will do? repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 446) <https://reviews.apache.org/r/49869/#comment210788> Why two levels of loop - use stack instead repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 503) <https://reviews.apache.org/r/49869/#comment210787> should be mapEdgeLabel repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java (line 886) <https://reviews.apache.org/r/49869/#comment210794> Add tests with lower bounds on map as well - Shwetha GS On July 21, 2016, 12:28 a.m., David Kantor wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49869/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 12:28 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-991 > https://issues.apache.org/jira/browse/ATLAS-991 > > > Repository: atlas > > > Description > ------- > > When deleting entities, avoid enforcing lower bound constraints (i.e. > required attributes) on all entities being deleted. Previously, only the > entities that were specifically requested for deletion were skipped when > enforcing required attributes, but any composite entities that were owned by > 'root' deletion candidates were not skipped, causing > NullRequiredAttributeException to be thrown unnecessarily. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java > 8d31c1b079a11291a87569fde6f2cb21d4258ca9 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > e301a00b16ad316a85714cbda4af43d01f11f4ad > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 81fb76e27019012fada88a70a13b4c5264c236bf > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java > 34842c3dc2904b123fecb5087aee357678b00156 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositoryHardDeleteTest.java > cc6026461bcd38b83dde0bcec2e835f5824e894f > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedRepositorySoftDeleteTest.java > 90bb635126a02cd38c045bd5332499c4481d3751 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java > 8a0a6bc60818c3dd58e12386c55a471de2508b5e > > Diff: https://reviews.apache.org/r/49869/diff/ > > > Testing > ------- > > Ran all unit and integration tests with no regressions. > > > Thanks, > > David Kantor > >
