----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50892/#review145139 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 8, 2016, 12:04 p.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50892/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 12:04 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1103 > https://issues.apache.org/jira/browse/ATLAS-1103 > > > Repository: atlas > > > Description > ------- > > The list of types fetched for DSL search is done on main page rendering and > not when the drop down is clicked. So, if a type is created after the main UI > page is opened, the type list is not refreshed > > > Diffs > ----- > > dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 3596732 > dashboardv2/public/js/utils/CommonViewFunction.js b8c8dea > dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js > e35186c > dashboardv2/public/js/views/graph/LineageLayoutView.js acf0d8e > dashboardv2/public/js/views/search/SearchLayoutView.js 6469c62 > dashboardv2/public/js/views/search/SearchResultLayoutView.js 865167d > dashboardv2/public/js/views/tag/addTagModalView.js c29ad25 > > Diff: https://reviews.apache.org/r/50892/diff/ > > > Testing > ------- > > ** Verified following scenario : ** > > * Added refresh button for DSL search which refresh the type dropdown. > * In multiple tag/term assign fetch search api get called after all tag/term > response are came. > > > Thanks, > > Kalyani Kashikar > >
