> On Aug. 30, 2016, 7:02 a.m., Vimal Sharma wrote: > > > > Vimal Sharma wrote: > Please generate the patch from atlas repo root. This patch is not > applying successfully since it has been created from inside webapp directory.
Generated the new patch from the Atlas root repo. > On Aug. 30, 2016, 7:02 a.m., Vimal Sharma wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java, > > line 186 > > <https://reviews.apache.org/r/51514/diff/1/?file=1488371#file1488371line186> > > > > It would make sense to add the first entity definition to definitionList The reason we're duplicating the entity definition is to maintain backward compatibility and make sure that any existing code doesn't break because of this. > On Aug. 30, 2016, 7:02 a.m., Vimal Sharma wrote: > > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java, > > line 203 > > <https://reviews.apache.org/r/51514/diff/1/?file=1488371#file1488371line203> > > > > Entity definition of first entity will get repeated since the first one > > has already been added in DEFINITION Same as above - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51514/#review147267 ----------------------------------------------------------- On Aug. 30, 2016, 3:44 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51514/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 3:44 p.m.) > > > Review request for atlas, Madhan Neethiraj and Suma Shivaprasad. > > > Repository: atlas > > > Description > ------- > > The bug states that the API response only shows one entity definition in the > response of an update/create call wherease the expectation seems to be of > getting the entire list of the entities that were created/updated. > > The fix adds the required capability by the means of a query parameter > responseType with the value as "full", if the API call is made with this > extra parameter, the response would contain an additional field called > "definitionList" which is of type JsonArray. If the parameter is unspecified, > the API response remains unaffected. > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java > 82016d0 > > Diff: https://reviews.apache.org/r/51514/diff/ > > > Testing > ------- > > > Thanks, > > Apoorv Naik > >
