----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51523/#review147413 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 30, 2016, 12:27 p.m., keval bhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51523/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 12:27 p.m.) > > > Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, > Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1140 > https://issues.apache.org/jira/browse/ATLAS-1140 > > > Repository: atlas > > > Description > ------- > > This patch contains for fix for bug in which all the attributes (self + > inherited ) were not present on UI while adding its value when tag is applied > to an entity. > > > Diffs > ----- > > dashboardv2/public/css/scss/override.scss fc05f78 > dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html f0826ca > dashboardv2/public/js/views/tag/addTagModalView.js 2a0b004 > > Diff: https://reviews.apache.org/r/51523/diff/ > > > Testing > ------- > > Tested UI by adding attributes with various combination (self + inherited) > and applied tag to entities is working fine and attributes and its values are > shown properly on entity page [ tag details section]. > > Created Tags,Applied tags to entities is working fine and UI is rendering > properly. > > > Thanks, > > keval bhatt > >
