-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51800/#review149034
-----------------------------------------------------------




client/src/main/java/org/apache/atlas/AtlasClient.java (line 1000)
<https://reviews.apache.org/r/51800/#comment216570>

    Return list<org.apache.atlas.typesystem.Struct>



client/src/main/java/org/apache/atlas/AtlasClient.java (line 1012)
<https://reviews.apache.org/r/51800/#comment216571>

    Return org.apache.atlas.typesystem.Struct



webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java (line 
658)
<https://reviews.apache.org/r/51800/#comment216572>

    metadataService.getTraitDefinition() loads the whole entity everytime for 
every trait of the entity. This is in-efficient. Use getEntityDefinition() once 
and read all the traits from entity definition
    
    You can also change metadataService.getTraitDefinition() to return 
org.apache.atlas.typesystem.Struct


- Shwetha GS


On Sept. 15, 2016, 6:53 a.m., Vimal Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51800/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 6:53 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Given entity id and trait name, support rest API that returns the trait 
> instance for the entity. Currently, the other way of getting it is 
> getEntity() which returns full entity with all trait instances
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 5ed79bc 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> 82016d0 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
>  a1988ef 
> 
> Diff: https://reviews.apache.org/r/51800/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> ATLAS-712-v2.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/13/b5079426-19d0-48f2-88f7-08e4e645bb32__ATLAS-712-v2.patch
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>

Reply via email to