David Radley commented on ATLAS-1178:

In looking at this Jira, I am looking to understand what this class with 
respect to others. 
I notice that this Interface and class has the name service in it, which 
implies it is dealing with json objects. It is in the ServerAPI project.
I suggest you consider renaming this class / Interface and move it out of the 
API project. I was thinking that a better name might be TypeSystemManager. 

Is the proposal here to remove all json awareness from the MetadataService 
interface and its default implementation and move this code into TypesResource 
and the like. I think this makes sense to avoid unnecessary cases of creaing 
json objects. Is the idea is that no json processing is done downstream of the 
Metadata interface? I notice AtlasClient.EntityResult is returned from some 
methods - are you proposing changing this to a POJO object and moving out any 
json creation as well?      

> APIs in DefaultMetadataService should return POJOs
> --------------------------------------------------
>                 Key: ATLAS-1178
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1178
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shwetha G S
> DefaultMetadataService APIs accept/return json strings and the rest APIs end 
> up serialising and deserialising everytime. DefaultMetadataService APIs are 
> internal APIs and should accept/return POJOs

This message was sent by Atlassian JIRA

Reply via email to