> On Oct. 5, 2016, 11:51 p.m., Shwetha GS wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java, > > line 232 > > <https://reviews.apache.org/r/52533/diff/1/?file=1522435#file1522435line232> > > > > This is a minor backward compatible change. We should set it to 1.1
you are right, this is not a major change, updated version to 1.1. Thanks - Sarath Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review151632 ----------------------------------------------------------- On Oct. 6, 2016, 10:29 p.m., Sarath Kumar Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52533/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 10:29 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1210 > https://issues.apache.org/jira/browse/ATLAS-1210 > > > Repository: atlas > > > Description > ------- > > for clients who have not updated to latest code, this patch adds the > "position" attribute to hive_column type and updates version to 2.0 > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 28078f4 > distro/src/main/assemblies/standalone-package.xml 53b034f > > repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java > c269c3a > src/main/patches/001-hive_column_add_position.json PRE-CREATION > > Diff: https://reviews.apache.org/r/52533/diff/ > > > Testing > ------- > > on older builds - updates the type by adding new attribute and updates > version to 2.0 > new builds - ignore the patch since version is already in 2.0 > > > Thanks, > > Sarath Kumar Subramanian > >
