> On Oct. 7, 2016, 7:39 a.m., Shwetha GS wrote: > > intg module should contain only the client side classes which is required > > for integration from external users. AtlasTypeRegistry on the other hand is > > the cache of all types on atlas service. So, AtlasTypeRegistry should be > > moved out to a server side module - either existing/new module is your > > choice. > > > > AtlasTypeRegistry.getAllTypeNames() - eventually for atlas to scale, > > caching all types in memory is not possible. GraphBackedTypeStore > > implements graph based type store wherein types are loaded on demand and is > > used by IBM. getAllTypeNames() can't be supported with > > GraphBackedTypeStore. In fact, all get all methods should be removed like > > getAllEnumDefs() etc. contains() method can be added instead > > > > @dave kantor, can you review the interfaces to make sure your usecases are > > covered?
Sure will wait for more comments and tweak accordingly > On Oct. 7, 2016, 7:39 a.m., Shwetha GS wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java, line 73 > > <https://reviews.apache.org/r/52585/diff/6/?file=1526122#file1526122line73> > > > > typo - ype to type Will fix. > On Oct. 7, 2016, 7:39 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java, > > line 275 > > <https://reviews.apache.org/r/52585/diff/6/?file=1526125#file1526125line275> > > > > why change the log formats, log statements at other places use {}. To > > be consistent, lets leave it as is? I think this got picked up from some stale patch. Will revert back to original format. > On Oct. 7, 2016, 7:39 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java, > > line 33 > > <https://reviews.apache.org/r/52585/diff/6/?file=1526133#file1526133line33> > > > > These are defined in Constants as well Will change. - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/#review151767 ----------------------------------------------------------- On Oct. 7, 2016, 8:09 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52585/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 8:09 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha > GS, and Suma Shivaprasad. > > > Repository: atlas > > > Description > ------- > > TypesREST implementation > > TODO: Update and delete operations need to be refined > > > Diffs > ----- > > .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java > a3fdbcc025bf5f56e7770015d55616ec83d2be64 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 096f061f16bba3ecb886d00ec66c98ad17c1e243 > repository/pom.xml 7a34331ce2876d9d9e916f96f1141d3efa91e959 > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java > b342e2700d454b0d6fba595b5cc01cd0e06bbdac > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java > 263ea465fda0b445a952943def9a6f7c49834f25 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 1ce87c9d306faa43fb9d3fdc491c4bcbdd7b2bdb > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 5c7cb2e8fa32b540f80beed40fb4f25a89d39c56 > > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java > 2e0414e2cee7ca3d5958650ac6abc8a290473545 > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasClassificationDefMapper.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEntityDefMapper.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEnumDefMapper.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasStructDefMapper.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/factory/AtlasMapperFactory.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasClassificationDefMapperV1.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEntityDefMapperV1.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEnumDefMapperV1.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasStructDefMapperV1.java > PRE-CREATION > repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/instance/AbstractInstanceStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/instance/AtlasInstanceStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/instance/ClassificationStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/instance/EntityStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/instance/StructStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/typedef/AbstractAtlasStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/typedef/AtlasTypeDefStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/typedef/ClassificationDefStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/typedef/EntityDefStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/typedef/EnumDefStore.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/typedef/StructDefStore.java > PRE-CREATION > webapp/pom.xml 8fe4b9bed7efefdcc623df2f8e9cfa6ef84d8514 > webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java > a1d3187cea0422988500195191de37732c7df56f > webapp/src/main/java/org/apache/atlas/web/rest/InstancesREST.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/RestModule.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java > 429df65a86aba1f5a40875e1554d09ec238fb9d2 > webapp/src/main/java/org/apache/atlas/web/util/TypeValidator.java > PRE-CREATION > webapp/src/main/resources/errorMessages.properties PRE-CREATION > webapp/src/main/webapp/WEB-INF/web.xml > e2a85e9865e52cc86cf385eae1dd6f0e95687a8e > > Diff: https://reviews.apache.org/r/52585/diff/ > > > Testing > ------- > > > Thanks, > > Apoorv Naik > >
