> On Oct. 14, 2016, 7:56 p.m., Apoorv Naik wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java, > > line 465 > > <https://reviews.apache.org/r/52895/diff/1/?file=1538481#file1538481line465> > > > > Did we move the sorting logic somewhere else ?
This method does not seem to be doing any sorting. If you are referring to order of create/update - enum/struct/classification/entity, then it is already handled in the caller of this method createTypesDef/updateTypesDef - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52895/#review152726 ----------------------------------------------------------- On Oct. 14, 2016, 7:40 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52895/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 7:40 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1225 > https://issues.apache.org/jira/browse/ATLAS-1225 > > > Repository: atlas > > > Description > ------- > > Updated AtlasTypeDefGraphStore to use AtlasTypesRegistry > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > ebfd535 > intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java bc95288 > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 1473c3a > intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 34f5d49 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java ca5bb21 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 096f061 > intg/src/main/java/org/apache/atlas/type/AtlasType.java a3f1b02 > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java f4683ff > intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java fcd22f8 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 8139fd4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 9c0e569 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java > 9afccbe > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > c4e7dcd > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > 9726530 > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 728bec3 > > Diff: https://reviews.apache.org/r/52895/diff/ > > > Testing > ------- > > all unit test pass successfully > > > Thanks, > > Madhan Neethiraj > >
