-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52995/
-----------------------------------------------------------

(Updated Oct. 18, 2016, 9:26 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha 
GS, and Suma Shivaprasad.


Bugs: ATLAS-1200
    https://issues.apache.org/jira/browse/ATLAS-1200


Repository: atlas


Description
-------

Enhanced AtlasBaseException class to accept AtlasErrorCode enum and parameters 
for the formatted error message.
AtlasErrorCode enum captures all AtlasErrors identified by a unique code such 
as AtlasE4001 etc.

Each error code has a error message/description which is mapped under 
errorMessage.properties (for I18N) and can be parameterized to provide more 
context about the failure.


Diffs (updated)
-----

  common/src/main/java/org/apache/atlas/AtlasConstants.java 
8521f630e202adc3024d7fd7a94a76c5a52771fa 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java 
3538f41355b23b60e79be4179cc7a05100bd7817 
  intg/src/main/resources/errorMessages.properties PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
 78cbd635ba8d5ac2c1ae5144fec685f102dfc66e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
 f36c0d681ccff1c77fe0a35a1049e8cd54577fae 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
 67ff1a0d842186e202ba14c3ba2a47193cbb7e2b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
 ea1b03b661f265abcdb11cc1d9827d6196475638 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 4b50aacbc57a8ebd9b25febff3fc044082d4009a 
  webapp/src/main/java/org/apache/atlas/web/errors/LoggingExceptionMapper.java 
9830269d35aed961f0eecdfa6a57edf93e982de5 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 
889c3dd0bf65c8bbfcb520ca6e9b72def07aed5f 
  webapp/src/main/webapp/WEB-INF/web.xml 
c5518142492dab0e343caf4cedbe8eb1a645364a 

Diff: https://reviews.apache.org/r/52995/diff/


Testing
-------

Tested will REST API calls.
Unit Tests coverage will be added as a part of the UT review request for 
TypesREST stores.


Thanks,

Apoorv Naik

Reply via email to