----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53007/#review153235 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java (line 32) <https://reviews.apache.org/r/53007/#comment222519> we are importing from wrong TYpeCategory here - it should be AtlasTYpe.TypeCategory - Suma Shivaprasad On Oct. 19, 2016, 12:17 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53007/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 12:17 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1230 > https://issues.apache.org/jira/browse/ATLAS-1230 > > > Repository: atlas > > > Description > ------- > > - Moved all methods that mutate the AtlasTypeRegistry to > AtlasTransientTypeRegistry. After the updates are validated in the transient > registry, AtlasTypeRegistry is updated with a call to > commitTransientTypeRegistry() > - added @Singleton annotation to AtlasTypeRegistry, so that the registry is > accessible anywhere > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 21a4037 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > d962bbe > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 7017d65 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java f2ab08b > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 5c32db2 > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java c3f17f4 > intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java e2db68e > > intg/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java > 577dccf > intg/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java > fbf1cc7 > intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java > f3b12ef > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java ec893a0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 14cc7c4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java > bdd65d3 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java > 191ca56 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java > 67ff1a0 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > b26fc13 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java > 4b50aac > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 889c3dd > > Diff: https://reviews.apache.org/r/53007/diff/ > > > Testing > ------- > > - updated the tests for the changes to AtlasTypeRegistry and verified that > the tests succeeded > > > Thanks, > > Madhan Neethiraj > >
