> On Oct. 31, 2016, 10:12 p.m., Apoorv Naik wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java, line 115 > > <https://reviews.apache.org/r/53156/diff/2/?file=1544797#file1544797line115> > > > > Can we use a search filter here to accomodate for fine tuned requests ?
Removed the methpod since this can be handled through getBySearchFilter on /entities > On Oct. 31, 2016, 10:12 p.m., Apoorv Naik wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java, line 87 > > <https://reviews.apache.org/r/53156/diff/2/?file=1544797#file1544797line87> > > > > Same here. Can we use PATCH here ? Will definitely give us more options > > or mutation capabilities to perform in one go. Rather than going at a > > per-attribute level PATCH command requires some code to be added to jersey on server side - https://github.com/jersey/jersey/tree/master/examples/http-patch AND also there are reported issues with using it via jersey client - http://stackoverflow.com/questions/22355235/patch-request-using-jersey-client Remove all partial update methods for now. We can decide whats the right way to do these and add fixes for patch as part of ATLAS code base if it comes to it as part of another jira - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53156/#review154325 ----------------------------------------------------------- On Nov. 1, 2016, 8:37 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53156/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 8:37 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1241 > https://issues.apache.org/jira/browse/ATLAS-1241 > > > Repository: atlas > > > Description > ------- > > AtlasEntityHeader - for concise entity representation > AtlasEntityWithAssociations - for entity represenation with wither associated > classifications, terms etc > EntityRest - for single entity operations > EntitiesRest - for multiple entity operations > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java > PRE-CREATION > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a > intg/src/test/java/org/apache/atlas/TestUtilsV2.java dcccc38 > pom.xml 62fc136 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > PRE-CREATION > webapp/pom.xml 82f307c > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java > PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/53156/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
