> On Nov. 9, 2016, 6:46 a.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java, > > line 59 > > <https://reviews.apache.org/r/53595/diff/2/?file=1559104#file1559104line59> > > > > will hit NPE - incorrect assignment here, swap the statements in if > > else block.
Good catch. Will rectify. > On Nov. 9, 2016, 6:46 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java, > > line 61 > > <https://reviews.apache.org/r/53595/diff/2/?file=1559114#file1559114line61> > > > > can move package name to import to improve readability. Used in > > multiple places. > > > > import org.apache.atlas.model.TypeCategory; There's another import with same name hence I've to use the fully qualified name. > On Nov. 9, 2016, 6:46 a.m., Sarath Subramanian wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java, line 399 > > <https://reviews.apache.org/r/53595/diff/2/?file=1559117#file1559117line399> > > > > can make the path simpler - GET /typedefs /typedefs is reserved for search - Apoorv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53595/#review155407 ----------------------------------------------------------- On Nov. 9, 2016, 5:27 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53595/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 5:27 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Bugs: ATLAS-1278 > https://issues.apache.org/jira/browse/ATLAS-1278 > > > Repository: atlas > > > Description > ------- > > Added minimal data structure for typedef calls > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/TypeCategory.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java e8092a5 > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c7dad29 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > d841977 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 7170ee4 > intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java e9a2021 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 0ebfa26 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c8c2216 > intg/src/main/java/org/apache/atlas/type/AtlasType.java a507bf4 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java > 43f93d4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java > 5babae5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 6dfe8cf > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java d0cb209 > > Diff: https://reviews.apache.org/r/53595/diff/ > > > Testing > ------- > > > Thanks, > > Apoorv Naik > >
