----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53748/#review156164 -----------------------------------------------------------
catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java (line 86) <https://reviews.apache.org/r/53748/#comment226303> Can we switch to/think of using Lombok instead which would make the code more concise and less error prone - https://projectlombok.org/features/index.html. We could use it later for Getter/Setters and other useful features - Suma Shivaprasad On Nov. 15, 2016, 3:33 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53748/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 3:33 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, > and Suma Shivaprasad. > > > Repository: atlas > > > Description > ------- > > Updated equals and hashCode signatures > > Using JDK7's built-in classes to simplify the code and make it more > readable/understandable. > > > Diffs > ----- > > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f > client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab > common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > d9c74ae > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java > 4ddd585 > intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java > 5921fea > intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb > > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java > a6c75ed > intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java > e489f33 > intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java > 61b7f91 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java > d953633 > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java > 2e34127 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java > 86e2388 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java > 582b095 > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java > a3929b3 > > notification/src/main/java/org/apache/atlas/notification/MessageVersion.java > 6ef407a > > notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java > fda588e > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > ed5b9fc > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 7e47d30 > typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java > 5b8e157 > typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java > 42280d0 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java > f556223 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java > 9cb0d0d > > typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java > ac3b5a3 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java > 8069422 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java > 18ef2ee > > typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java > c9316cc > webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76 > > Diff: https://reviews.apache.org/r/53748/diff/ > > > Testing > ------- > > Working on executing all tests > > > Thanks, > > Apoorv Naik > >
