----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54166/#review157450 -----------------------------------------------------------
- nice work with UI to create/edit entities - for array type of attributes (like hive_table.aliases), editing an existing entity causes null value to be saved - perhaps because empty value is displayed in the UI though the entity has values (in the store). Please review and update to fix this issue. - Madhan Neethiraj On Nov. 29, 2016, 2:56 p.m., Kalyani Kashikar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54166/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 2:56 p.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad. > > > Bugs: ATLAS-1193 > https://issues.apache.org/jira/browse/ATLAS-1193 > > > Repository: atlas > > > Description > ------- > > * New UI for create/edit entities of different types. > * New UI for create/edit entity is integrated with new v2 api. > > > Diffs > ----- > > 3party-licenses/datetimepicker-LICENSE PRE-CREATION > dashboardv2/gruntfile.js a252f1d > dashboardv2/public/css/scss/form.scss e17b7bb > dashboardv2/public/css/scss/search.scss 24b2212 > dashboardv2/public/css/scss/tag.scss fa194fa > dashboardv2/public/index.html 04edcee > dashboardv2/public/js/collection/VEntityList.js 75e6733 > dashboardv2/public/js/collection/VSearchList.js bcdecd3 > > dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js > PRE-CREATION > > dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css > PRE-CREATION > > dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_444444_256x240.png > PRE-CREATION > > dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_555555_256x240.png > PRE-CREATION > > dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777620_256x240.png > PRE-CREATION > > dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777777_256x240.png > PRE-CREATION > > dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_cc0000_256x240.png > PRE-CREATION > > dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_ffffff_256x240.png > PRE-CREATION > dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.css 76845f2 > dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.js 8951532 > dashboardv2/public/js/main.js 2b005a9 > dashboardv2/public/js/models/VEntity.js cd84e9d > dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html > f34bcea > dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html > PRE-CREATION > dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 4706ba3 > dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION > dashboardv2/public/js/views/search/SearchLayoutView.js f2b8a38 > dashboardv2/public/js/views/search/SearchResultLayoutView.js 2eca6a1 > > Diff: https://reviews.apache.org/r/54166/diff/ > > > Testing > ------- > > * Created entities for all the entity type and also edited with edit UI. > * Verified with new api. > > > Thanks, > > Kalyani Kashikar > >
