----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/#review157719 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 77) <https://reviews.apache.org/r/54287/#comment228336> Can we use a HashMap here so that while adding an element, we don't have to iterate over the entire list to determine its membership. intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 148) <https://reviews.apache.org/r/54287/#comment228340> Please consider using HashMap. repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java (line 154) <https://reviews.apache.org/r/54287/#comment228338> Can you log this instead - Vimal Sharma On Dec. 2, 2016, 3:11 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54287/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 3:11 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad. > > > Bugs: ATLAS-1308 > https://issues.apache.org/jira/browse/ATLAS-1308 > > > Repository: atlas > > > Description > ------- > > Model and implement the new Discovery REST API's for the following search > types: > * DSL Search > * Full Text Search > and retrieve search results in a structured model using AtlasEntityHeader > information. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 84d8173 > > intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java > PRE-CREATION > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > d9c74ae > repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java > d3903fb > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > PRE-CREATION > repository/src/main/scala/org/apache/atlas/query/Expressions.scala 297aa2b > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/54287/diff/ > > > Testing > ------- > > UTs in progress, tested using POSTMAN rest client. > > > Thanks, > > Sarath Subramanian > >
