-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54741/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and
Vimal Sharma.
Bugs: ATLAS-1377
https://issues.apache.org/jira/browse/ATLAS-1377
Repository: atlas
Description
-------
This patch contains fix for ATLAS-1377 :- Escaping comma in for LDAP properties.
Diffs
-----
distro/src/conf/atlas-application.properties eea46a6
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java
aea939a
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java
468daf6
Diff: https://reviews.apache.org/r/54741/diff/
Testing
-------
Tested both AD and LDAP logins with following atlas configaration.
######## LDAP properties #########
atlas.authentication.method.ldap.type=LDAP
atlas.authentication.method.ldap.url=ldap://XXX.XX.XX.XX:33389
atlas.authentication.method.ldap.userDNpattern=uid={0},ou=people,dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.groupSearchBase=dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.groupSearchFilter=(member=uid={0},ou=people,dc=hadoop,dc=apache,dc=org)
atlas.authentication.method.ldap.groupRoleAttribute=cn
atlas.authentication.method.ldap.base.dn=dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.bind.dn=uid=admin,ou=people,dc=hadoop,dc=apache,dc=org
atlas.authentication.method.ldap.bind.password=p@$$$$wOrd
atlas.authentication.method.ldap.referral=ignore
atlas.authentication.method.ldap.user.searchfilter=(uid={0})
atlas.authentication.method.ldap.default.role=<default role>
######### Active directory properties #######
atlas.authentication.method.ldap.type=AD
atlas.authentication.method.ldap.ad.domain=example.com
atlas.authentication.method.ldap.ad.url=ldap://XXX.XX.XX.XX:389
atlas.authentication.method.ldap.ad.base.dn=(sAMAccountName={0})
atlas.authentication.method.ldap.ad.bind.dn=cn=admin,dc=example,dc=com
atlas.authentication.method.ldap.ad.bind.password=p@$$$$wOrd
atlas.authentication.method.ldap.ad.referral=ignore
atlas.authentication.method.ldap.ad.user.searchfilter=(sAMAccountName={0})
atlas.authentication.method.ldap.ad.default.role=ROLE_USER
Thanks,
Nixon Rodrigues
